rohitmishr1484 edited a comment on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672391444
Hi @HyukjinKwon,
I was not sure how to add you as a Reviewer for this Pull request, thus
adding this comment. I would like to mention a few points:
1. Baseline description: I have used this pull request as a reference since
this is my first pull request- #29385
or https://github.com/apache/spark/pull/29385.
2. Most of the information used for the "Installation Page" has come from
Koalas
documentation-https://koalas.readthedocs.io/en/latest/getting_started/install.html.
Am I supposed to mention this as reference/credit anywhere in this
documentation?
3. Personally I have used only PyPI as an installation mechanism thus
haven't tried the other three. A prerequisite for PyPI installation was the
availability of JAVA 8 path in JAVA_HOME environment variable. Please let me
know if that's something I need to add explicitly mention in the "Dependencies"
section.
4. Where ever necessary I have updated the links.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
