venkata91 commented on a change in pull request #29411:
URL: https://github.com/apache/spark/pull/29411#discussion_r469002807
##########
File path:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala
##########
@@ -79,7 +79,7 @@ class SparkSubmitUtilsSuite extends SparkFunSuite with
BeforeAndAfterAll {
test("create additional resolvers") {
val repos = "a/1,b/2,c/3"
- val settings = SparkSubmitUtils.buildIvySettings(Option(repos), None)
+ val settings = SparkSubmitUtils.buildIvySettings(Option(repos),
Some(tempIvyPath))
Review comment:
Yes, this is only required for tests and if you check the test
`SPARK-10878: test resolution files cleaned after resolving artifact` at the
end, it checks whether the resolution files are cleaned at the end or not, but
that use `tempIvyPath` whereas when we don't pass it here what happens is it
picks user's .ivy location. This change is slightly separate as its just
standardizes using `tempIvyPath` across the tests in this suite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
