agrawaldevesh commented on a change in pull request #29367:
URL: https://github.com/apache/spark/pull/29367#discussion_r469030334
##########
File path:
core/src/test/scala/org/apache/spark/deploy/DecommissionWorkerSuite.scala
##########
@@ -242,8 +242,10 @@ class DecommissionWorkerSuite
assert(jobResult === 2)
}
// 6 tasks: 2 from first stage, 2 rerun again from first stage, 2nd stage
attempt 1 and 2.
- val tasksSeen = listener.getTasksFinished()
Review comment:
This will take me a while to fix. I will make this fix against the
master branch.
Apparently #29211 broke some of my state keeping that I was relying on in
#29032 :-P. Let me think through how to fix this for real. So I think the test
failure is real and it is worrisome that it isn't failing as frequently as it
should.
Stay tuned for a PR to fix this but in the meanwhile please back out this
test change. Thanks for surfacing this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
