beliefer commented on a change in pull request #28685: URL: https://github.com/apache/spark/pull/28685#discussion_r470379655
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ########## @@ -137,7 +137,11 @@ trait WindowExecBase extends UnaryExecNode { function match { case AggregateExpression(f, _, _, _, _) => collect("AGGREGATE", frame, e, f) case f: AggregateWindowFunction => collect("AGGREGATE", frame, e, f) - case f: OffsetWindowFunction => collect("OFFSET", frame, e, f) + case f: OffsetWindowFunction => if (f.isWholeBased) { Review comment: According to the plan, `first_value` and `last_value` need to be realized. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org