emkornfield commented on a change in pull request #29430:
URL: https://github.com/apache/spark/pull/29430#discussion_r470845244
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
##########
@@ -371,6 +371,25 @@ class DataSourceV2Suite extends QueryTest with
SharedSQLContext {
}
}
}
+
+ test("SPARK-32609: DataSourceV2 with different pushedfilters should be
different") {
+ def getScanExec(query: DataFrame): DataSourceV2ScanExec = {
+ query.queryExecution.executedPlan.collect {
+ case d: DataSourceV2ScanExec => d
+ }.head
+ }
+
+ Seq(classOf[AdvancedDataSourceV2],
classOf[JavaAdvancedDataSourceV2]).foreach { cls =>
+ withClue(cls.getName) {
+ val df = spark.read.format(cls.getName).load()
+ val q1 = df.select('i).filter('i > 6)
+ val q2 = df.select('i).filter('i > 5)
Review comment:
i think it might also be good to verify that two dataframes with the
same filter compare to equal (i.e. we don't break the exchange reuse)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
