agrawaldevesh commented on a change in pull request #29422:
URL: https://github.com/apache/spark/pull/29422#discussion_r470889570
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -1027,7 +1036,15 @@ private[spark] class TaskSchedulerImpl(
}
}
- executorsPendingDecommission -= executorId
+
+ val decomInfo = executorsPendingDecommission.get(executorId)
+ if (decomInfo.isDefined) {
+ val rememberSeconds =
+ conf.getInt("spark.decommissioningRememberAfterRemoval.seconds", 60)
+ val gcSecond = TimeUnit.MILLISECONDS.toSeconds(clock.getTimeMillis()) +
rememberSeconds
+ decommissioningExecutorsToGc.computeIfAbsent(gcSecond, _ =>
mutable.ArrayBuffer.empty) +=
+ executorId
+ }
Review comment:
Hmm, no. the removal code only shares the piece about
`TimeUnit.MILLISECONDS.toSeconds(clock.getTimeMillis())`, it does not share the
rest of the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
