viirya commented on a change in pull request #29456: URL: https://github.com/apache/spark/pull/29456#discussion_r471922554
########## File path: R/pkg/tests/run-all.R ########## @@ -61,15 +61,18 @@ if (identical(Sys.getenv("NOT_CRAN"), "true")) { set.seed(42) # TODO (SPARK-30663) To be removed once testthat 1.x is removed from all builds - if (grepl("^1\\..*", packageVersion("testthat"))) { + if (packageVersion("testthat")$major <= 1) { # testthat 1.x test_runner <- testthat:::run_tests reporter <- "summary" - } else { # testthat >= 2.0.0 test_runner <- testthat:::test_package_dir - reporter <- testthat::default_reporter() + dir.create("target/test-reports", showWarnings = FALSE) + reporter <- MultiReporter$new(list( + SummaryReporter$new(), + JunitReporter$new(file = "target/test-reports/test-results.xml") Review comment: Is it only supported by testthat 2.0+? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org