Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/5294#discussion_r27530532
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -809,7 +809,13 @@ object Client extends Logging {
}
}
addFileToClasspath(new URI(sparkJar(sparkConf)), SPARK_JAR, env)
- populateHadoopClasspath(conf, env)
+ // Since we have a spark assembly that is including all the yarn and
other dependencies we need,
+ // add an option to allow the user to not include the cluster default
yarn/mapreduce application
+ // classpaths when running spark on yarn.
+ val isPopulateHadoopClasspath =
conf.getBoolean("spark.yarn.cluster.classpath.populate", true)
--- End diff --
This name seems a little weird to me. In particular, periods should be
used to separate config namespaces, not in places where we'd use spaces in
English. I'd go with something like `spark.yarn.includeClusterHadoopJars` or
`spark.yarn.includeClusterHadoopClasspath`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
