cloud-fan commented on a change in pull request #29452: URL: https://github.com/apache/spark/pull/29452#discussion_r472767373
########## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ########## @@ -926,18 +926,21 @@ private[spark] class TaskSchedulerImpl( // and some of those can have isHostDecommissioned false. We merge them such that // if we heard isHostDecommissioned ever true, then we keep that one since it is // most likely coming from the cluster manager and thus authoritative - val oldDecomInfo = executorsPendingDecommission.get(executorId) - if (!oldDecomInfo.exists(_.isHostDecommissioned)) { - executorsPendingDecommission(executorId) = decommissionInfo + val oldDecomState = executorsPendingDecommission.get(executorId) + if (!oldDecomState.exists(_.isHostDecommissioned)) { + executorsPendingDecommission(executorId) = ExecutorDecommissionState( + decommissionInfo.message, + oldDecomState.map(_.).getOrElse(clock.getTimeMillis()), Review comment: `map(_.)`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org