tanelk commented on a change in pull request #29515:
URL: https://github.com/apache/spark/pull/29515#discussion_r475201468
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -793,7 +793,9 @@ case class EqualTo(left: Expression, right: Expression)
// | FALSE | FALSE | TRUE | UNKNOWN |
// | UNKNOWN | UNKNOWN | UNKNOWN | UNKNOWN |
// +---------+---------+---------+---------+
- protected override def nullSafeEval(left: Any, right: Any): Any =
ordering.equiv(left, right)
+ protected override def nullSafeEval(left: Any, right: Any): Any = {
+ left == right || ordering.equiv(left, right)
Review comment:
`NormalizeNaNAndZero` can't help here, because
`checkConsistencyBetweenInterpretedAndCodegen` is done without optimizers.
Also it could introduce new correctness issues with `atan2(-0.0, x)` and
`1.0 / -0.0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
