holdenk commented on a change in pull request #29491:
URL: https://github.com/apache/spark/pull/29491#discussion_r474849547
##########
File path: apt.txt
##########
@@ -0,0 +1 @@
+openjdk-8-jre
Review comment:
Binder sub dir sounds good.
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -217,7 +217,7 @@ jobs:
run: |
# TODO(SPARK-32407): Sphinx 3.1+ does not correctly index nested
classes.
# See also https://github.com/sphinx-doc/sphinx/issues/7551.
- pip3 install flake8 'sphinx<3.1.0' numpy pydata_sphinx_theme
+ pip3 install flake8 'sphinx<3.1.0' numpy pydata_sphinx_theme ipython
nbsphinx
Review comment:
Should we have a `requirements.txt` somewhere instead?
##########
File path: apt.txt
##########
@@ -0,0 +1 @@
+openjdk-8-jre
Review comment:
Any particular reason for JDK8 instead of 11?
##########
File path: dev/create-release/spark-rm/Dockerfile
##########
@@ -36,7 +36,7 @@ ARG APT_INSTALL="apt-get install --no-install-recommends -y"
# TODO(SPARK-32407): Sphinx 3.1+ does not correctly index nested classes.
# See also https://github.com/sphinx-doc/sphinx/issues/7551.
# We should use the latest Sphinx version once this is fixed.
-ARG PIP_PKGS="sphinx==3.0.4 mkdocs==1.0.4 numpy==1.18.1
pydata_sphinx_theme==0.3.1"
+ARG PIP_PKGS="sphinx==3.0.4 mkdocs==1.0.4 numpy==1.18.1
pydata_sphinx_theme==0.3.1 ipython==7.16.1 nbsphinx==0.7.1"
Review comment:
this makes me think we should have a shared requirements.txt somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
