peter-toth commented on a change in pull request #29572: URL: https://github.com/apache/spark/pull/29572#discussion_r479625983
########## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ########## @@ -749,6 +749,15 @@ class JoinSuite extends QueryTest with SharedSparkSession with AdaptiveSparkPlan ) } + // LEFT SEMI JOIN without bound condition does not use [[ExternalAppendOnlyUnsafeRowArray]] + // so should not cause any spill + assertNotSpilled(sparkContext, "left semi join") { Review comment: Without this fix this UT fails. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org