maropu commented on a change in pull request #29577:
URL: https://github.com/apache/spark/pull/29577#discussion_r479766922
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -541,7 +541,8 @@ object Overlay {
Spark ANSI SQL
> SELECT _FUNC_(encode('Spark SQL', 'utf-8') PLACING encode('tructured',
'utf-8') FROM 2 FOR 4);
Structured SQL
- """)
+ """,
+ since = "3.0.0")
Review comment:
Is this change related to this PR? btw, could we add tests to check if a
`since` field is defined in all the expressions? I think it is important to
define this field when adding a new expr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
