HyukjinKwon commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r479940442
##########
File path: python/pyspark/cloudpickle.pyi
##########
@@ -0,0 +1,86 @@
+#
Review comment:
I believe this file can be removed. It's a copy of
[cloudpickle](https://github.com/cloudpipe/cloudpickle), which should be
separate from PySpark. I believe it makes less sense to type this file.
BTW, should we maybe start it with typing only exposed APIs for now? I think
having type hints in internal packages has less benefits (only to PySpark dev)
and it's arguable to maintain it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
