cchighman commented on a change in pull request #28841: URL: https://github.com/apache/spark/pull/28841#discussion_r483995638
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/PathFilterSuite.scala ########## @@ -0,0 +1,553 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.datasources + +import java.io.File +import java.time.{LocalDateTime, ZoneOffset} +import java.time.format.DateTimeFormatter + +import scala.util.Random + +import org.apache.spark.sql.{AnalysisException, QueryTest, Row} +import org.apache.spark.sql.catalyst.util.{stringToFile, DateTimeUtils} +import org.apache.spark.sql.test.SharedSparkSession + + +class PathFilterSuite extends QueryTest with SharedSparkSession { + import testImplicits._ + + def createSingleFile(dir: File): File = { + val file = new File(dir, "temp" + Random.nextInt(1000) + ".csv") + stringToFile(file, "text") + } + + def setFileTime(time: LocalDateTime, file: File): Boolean = { + val sameTime = time.toEpochSecond(ZoneOffset.UTC) + file.setLastModified(sameTime * 1000) + } + + def setPlusFileTime(time: LocalDateTime, file: File, interval: Long): Boolean = { + val sameTime = time.plusDays(interval).toEpochSecond(ZoneOffset.UTC) + file.setLastModified(sameTime * 1000) + } + + def setMinusFileTime(time: LocalDateTime, file: File, interval: Long): Boolean = { + val sameTime = time.minusDays(interval).toEpochSecond(ZoneOffset.UTC) + file.setLastModified(sameTime * 1000) + } + + def formatTime(time: LocalDateTime): String = { + time.format(DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss")) + } + + test("SPARK-31962: when modifiedBefore specified" + + " and sharing same timestamp with file last modified time.") { + withTempDir { dir => + val file = createSingleFile(dir) + val time = LocalDateTime.now(ZoneOffset.UTC) + setFileTime(time, file) + val formattedTime = formatTime(time) + + val msg = intercept[AnalysisException] { + spark.read + .option("modifiedBefore", formattedTime) Review comment: I updated pathFilters source as well after re-running scalafmt. The only issue I noticed is that Spark's current scalafmt configuration has different formatting than which you suggested. Example  In this case, I defaulted with the results from scalafmt for consistency. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
