AngersZhuuuu commented on a change in pull request #29656:
URL: https://github.com/apache/spark/pull/29656#discussion_r484209443
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala
##########
@@ -69,7 +69,7 @@ private[hive] class SparkSQLSessionManager(hiveServer:
HiveServer2, sqlContext:
setConfMap(ctx, hiveSessionState.getOverriddenConfigurations)
setConfMap(ctx, hiveSessionState.getHiveVariables)
if (sessionConf != null && sessionConf.containsKey("use:database")) {
- ctx.sql(s"use ${sessionConf.get("use:database")}")
+
ctx.sessionState.catalog.setCurrentDatabase(sessionConf.get("use:database"))
Review comment:
> just to be clear, is this just a small refactoring?
In this way we can avoid a lot of process part, but seems I have miss a
important problem that user may write a db name wrong such as `aa.cc`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
