Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/3247#discussion_r27717014 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -26,9 +26,12 @@ trait FunctionRegistry { def registerFunction(name: String, builder: FunctionBuilder): Unit - def lookupFunction(name: String, children: Seq[Expression]): Expression - def caseSensitive: Boolean + + def lookupFunction( + name: String, + children: Seq[Expression], + distinct: Boolean = false): Expression --- End diff -- We need to have careful considerations on this change because I think `distinct` is not related to simple UDFs and UDTF.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org