Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/5116#issuecomment-89208184
@andrewor14 Thanks very much for comments.
I totally agree with you. Actually these two points are also in my main
concern.
About first issue, considering client now just submits app once and exit
with no retry when submit failed, even if the lost master recovers, it has
never opptunity to accept request from one submit in same client. So we could
add some comments here and improve it when we try to support retry in client
submission.
About Issue No.2, return message is kinda weak flag too. Now I couldn't see
a way that can achive backward compatibility with new parameter added. Perhaps
we could make the message contents (like "Can only") common field to avoid
reword one-side? Though it is a hack, we can give it a try.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
