cloud-fan commented on a change in pull request #29687:
URL: https://github.com/apache/spark/pull/29687#discussion_r486038353
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -130,7 +130,8 @@ private[hive] class SparkGetColumnsOperation(
* For array, map, string, and binaries, the column size is variable, return
null as unknown.
*/
private def getColumnSize(typ: DataType): Option[Int] = typ match {
- case dt @ (BooleanType | _: NumericType | DateType | TimestampType |
CalendarIntervalType) =>
+ case dt @ (BooleanType | _: NumericType | DateType | TimestampType |
+ CalendarIntervalType | NullType) =>
Review comment:
so it's not a test only PR. Can we remove [TEST] from PR title?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
