Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5227#discussion_r27726488
--- Diff: launcher/src/main/java/org/apache/spark/launcher/Main.java ---
@@ -101,12 +101,9 @@ public static void main(String[] argsArray) throws
Exception {
* The method quotes all arguments so that spaces are handled as
expected. Quotes within arguments
* are "double quoted" (which is batch for escaping a quote). This page
has more details about
* quoting and other batch script fun stuff:
http://ss64.com/nt/syntax-esc.html
- *
- * The command is executed using "cmd /c" and formatted in single line,
since that's the
- * easiest way to consume this from a batch script (see
spark-class2.cmd).
*/
private static String prepareWindowsCommand(List<String> cmd,
Map<String, String> childEnv) {
- StringBuilder cmdline = new StringBuilder("cmd /c \"");
+ StringBuilder cmdline = new StringBuilder("");
--- End diff --
OK I trust your judgment on this. This is confined to Windows support and I
believe you're closest to this code. Note that you don't need the argument `""`
now and there's still an indent issue above. Take a moment to see if it would
be easy to add a test in `SparkLauncherSuite`; not sure if it is. Otherwise
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
