zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r487129652
##########
File path: dev/tox.ini
##########
@@ -20,5 +20,5 @@
exclude=python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,wor
[flake8]
select = E901,E999,F821,F822,F823,F401,F405
-exclude =
python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,work/*/*.py,python/.eggs/*,dist/*,.git/*
+exclude =
python/pyspark/cloudpickle/*.py,shared.py*,python/docs/source/conf.py,work/*/*.py,python/.eggs/*,dist/*,.git/*,python/out,python/pyspark/sql/pandas/functions.pyi,python/pyspark/sql/column.pyi,python/pyspark/worker.pyi,python/pyspark/java_gateway.pyi
Review comment:
> Personally, I would require mypy to be added in this PR As well.
Otherwise we run the risk that the annotations might go out of sync quickly.
In general I see your point, however I wanted to avoid duplicating your work
from https://github.com/apache/spark/pull/29180 and we cannot setup the
environment anyway.
##########
File path: dev/tox.ini
##########
@@ -20,5 +20,5 @@
exclude=python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,wor
[flake8]
select = E901,E999,F821,F822,F823,F401,F405
-exclude =
python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,work/*/*.py,python/.eggs/*,dist/*,.git/*
+exclude =
python/pyspark/cloudpickle/*.py,shared.py*,python/docs/source/conf.py,work/*/*.py,python/.eggs/*,dist/*,.git/*,python/out,python/pyspark/sql/pandas/functions.pyi,python/pyspark/sql/column.pyi,python/pyspark/worker.pyi,python/pyspark/java_gateway.pyi
Review comment:
> Personally, I would require mypy to be added in this PR As well.
Otherwise we run the risk that the annotations might go out of sync quickly.
In general I see your point, however I wanted to avoid duplicating your work
from https://github.com/apache/spark/pull/29180 and we cannot setup the
environment anyway.
##########
File path: dev/tox.ini
##########
@@ -20,5 +20,5 @@
exclude=python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,wor
[flake8]
select = E901,E999,F821,F822,F823,F401,F405
-exclude =
python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,work/*/*.py,python/.eggs/*,dist/*,.git/*
+exclude =
python/pyspark/cloudpickle/*.py,shared.py*,python/docs/source/conf.py,work/*/*.py,python/.eggs/*,dist/*,.git/*,python/out,python/pyspark/sql/pandas/functions.pyi,python/pyspark/sql/column.pyi,python/pyspark/worker.pyi,python/pyspark/java_gateway.pyi
Review comment:
> Personally, I would require mypy to be added in this PR As well.
Otherwise we run the risk that the annotations might go out of sync quickly.
In general I see your point, however I wanted to avoid duplicating your work
from https://github.com/apache/spark/pull/29180 and we cannot setup the
environment anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
