dongjoon-hyun commented on a change in pull request #29761:
URL: https://github.com/apache/spark/pull/29761#discussion_r489981140
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2206,39 +2206,63 @@ abstract class SQLQuerySuiteBase extends QueryTest with
SQLTestUtils with TestHi
}
}
- test("SPARK-21912 ORC/Parquet table should not create invalid column names")
{
+ test("SPARK-21912 Parquet table should not create invalid column names") {
Seq(" ", ",", ";", "{", "}", "(", ")", "\n", "\t", "=").foreach { name =>
- Seq("ORC", "PARQUET").foreach { source =>
- withTable("t21912") {
- val m = intercept[AnalysisException] {
- sql(s"CREATE TABLE t21912(`col$name` INT) USING $source")
- }.getMessage
- assert(m.contains(s"contains invalid character(s)"))
+ val source = "PARQUET"
+ withTable("t21912") {
+ val m = intercept[AnalysisException] {
+ sql(s"CREATE TABLE t21912(`col$name` INT) USING $source")
+ }.getMessage
+ assert(m.contains(s"contains invalid character(s)"))
- val m1 = intercept[AnalysisException] {
- sql(s"CREATE TABLE t21912 STORED AS $source AS SELECT 1
`col$name`")
- }.getMessage
- assert(m1.contains(s"contains invalid character(s)"))
+ val m1 = intercept[AnalysisException] {
+ sql(s"CREATE TABLE t21912 STORED AS $source AS SELECT 1 `col$name`")
+ }.getMessage
+ assert(m1.contains(s"contains invalid character(s)"))
+
+ val m2 = intercept[AnalysisException] {
+ sql(s"CREATE TABLE t21912 USING $source AS SELECT 1 `col$name`")
+ }.getMessage
+ assert(m2.contains(s"contains invalid character(s)"))
- val m2 = intercept[AnalysisException] {
- sql(s"CREATE TABLE t21912 USING $source AS SELECT 1 `col$name`")
+ withSQLConf(HiveUtils.CONVERT_METASTORE_PARQUET.key -> "false") {
+ val m3 = intercept[AnalysisException] {
+ sql(s"CREATE TABLE t21912(`col$name` INT) USING hive OPTIONS
(fileFormat '$source')")
}.getMessage
- assert(m2.contains(s"contains invalid character(s)"))
+ assert(m3.contains(s"contains invalid character(s)"))
+ }
- withSQLConf(HiveUtils.CONVERT_METASTORE_PARQUET.key -> "false") {
- val m3 = intercept[AnalysisException] {
- sql(s"CREATE TABLE t21912(`col$name` INT) USING hive OPTIONS
(fileFormat '$source')")
- }.getMessage
- assert(m3.contains(s"contains invalid character(s)"))
- }
+ sql(s"CREATE TABLE t21912(`col` INT) USING $source")
+ val m4 = intercept[AnalysisException] {
+ sql(s"ALTER TABLE t21912 ADD COLUMNS(`col$name` INT)")
+ }.getMessage
+ assert(m4.contains(s"contains invalid character(s)"))
+ }
+ }
+ }
- sql(s"CREATE TABLE t21912(`col` INT) USING $source")
- val m4 = intercept[AnalysisException] {
- sql(s"ALTER TABLE t21912 ADD COLUMNS(`col$name` INT)")
- }.getMessage
- assert(m4.contains(s"contains invalid character(s)"))
+ test("SPARK-32889 ORC table column name supports special characters like $
eg.") {
Review comment:
Could you use the following line?
```scala
test("SPARK-32889: ORC table column name supports special characters") {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
