cloud-fan commented on a change in pull request #29767:
URL: https://github.com/apache/spark/pull/29767#discussion_r490005962
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala
##########
@@ -815,3 +818,131 @@ class DataStreamReaderWriterSuite extends StreamTest with
BeforeAndAfter {
}
}
}
+
+class DataStreamWriterWithTableSuite extends StreamTest with BeforeAndAfter {
+ import testImplicits._
+
+ before {
+ spark.conf.set("spark.sql.catalog.testcat",
classOf[InMemoryTableCatalog].getName)
+ }
+
+ after {
+ spark.sessionState.catalogManager.reset()
+ spark.sessionState.conf.clear()
+ sqlContext.streams.active.foreach(_.stop())
+ }
+
+ test("write to table with custom catalog & no namespace") {
+ val tableIdentifier = "testcat.table_name"
+
+ spark.sql(s"CREATE TABLE $tableIdentifier (id bigint, data string) USING
foo")
+ checkAnswer(spark.table(tableIdentifier), Seq.empty)
+
+ runTestWithStreamAppend(tableIdentifier)
+ }
+
+ test("write to table with custom catalog & namespace") {
+ spark.sql("CREATE NAMESPACE testcat.ns")
+
+ val tableIdentifier = "testcat.ns.table_name"
+
+ spark.sql(s"CREATE TABLE $tableIdentifier (id bigint, data string) USING
foo")
+ checkAnswer(spark.table(tableIdentifier), Seq.empty)
+
+ runTestWithStreamAppend(tableIdentifier)
+ }
+
+ test("write to table with default session catalog") {
+ try {
+ val v2Source = classOf[FakeV2Provider].getName
+ spark.conf.set(V2_SESSION_CATALOG_IMPLEMENTATION.key,
+ classOf[InMemoryTableSessionCatalog].getName)
+
+ spark.sql("CREATE NAMESPACE ns")
+
+ val tableIdentifier = "ns.table_name"
+ spark.sql(s"CREATE TABLE $tableIdentifier (id bigint, data string) USING
$v2Source")
+ checkAnswer(spark.table(tableIdentifier), Seq.empty)
+
+ runTestWithStreamAppend(tableIdentifier)
+ } finally {
+ spark.conf.unset(V2_SESSION_CATALOG_IMPLEMENTATION.key)
Review comment:
In `after` we clear out everything, so this is not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
