cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695160233
> These timestamps should be inclusive or exclusive? e.g., `(modifiedAfter, modifiedBefore)`, `[modifiedAfter, modifiedBefore]`... Looks like the current code follows `(modifiedAfter, modifiedBefore]`? Anyway, I think we need to test all the boundary cases. @maropu's request to explore these type of conditions as test cases led to finding a corner case that was missed. Four tests were added to provide protection around the bounded contexts of our timeZone parameter. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
