mundaym commented on a change in pull request #29815:
URL: https://github.com/apache/spark/pull/29815#discussion_r491887508
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
##########
@@ -392,15 +392,8 @@ public void putFloats(int rowId, int count, float[] src,
int srcIndex) {
@Override
public void putFloats(int rowId, int count, byte[] src, int srcIndex) {
- if (!bigEndianPlatform) {
- Platform.copyMemory(src, Platform.BYTE_ARRAY_OFFSET + srcIndex,
floatData,
- Platform.DOUBLE_ARRAY_OFFSET + rowId * 4L, count * 4L);
- } else {
- ByteBuffer bb = ByteBuffer.wrap(src).order(ByteOrder.BIG_ENDIAN);
- for (int i = 0; i < count; ++i) {
- floatData[i + rowId] = bb.getFloat(srcIndex + (4 * i));
- }
- }
+ Platform.copyMemory(src, Platform.BYTE_ARRAY_OFFSET + srcIndex, floatData,
+ Platform.DOUBLE_ARRAY_OFFSET + rowId * 4L, count * 4L);
Review comment:
Existing bug, but should this be FLOAT_ARRAY_OFFSET (I guess they are
the same value)? I can fix this here or can do a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
