Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/586#issuecomment-41638782
Hey @sryza thanks for looking at this. Any chance you could test this on a
YARN cluster and make sure it all works well. Since we have no test coverage
here, it would be good to just take it for a whirl before we merge it.
Another thing that's be bugging me is I'm not sure whether or not we handle
quoted strings correctly in the way we ship this stuff around YARN. For
instance, what if someone has:
SPARK_JAVA_OPTS="-Dspark.app.name=\"Sandy's App\" -XX:+UseConcMarkSweepGC"
I want to make sure we don't regress behavior from where we previously used
an environment variable. I don't think we handle these in `spark-submit`
arguments (we'd need to modify our parser a bit), but it would be nice to make
sure that if someone puts a quoted string int he defaults file or in
SPARK_JAVA_OPTS it will work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
