Ngone51 commented on a change in pull request #29644:
URL: https://github.com/apache/spark/pull/29644#discussion_r492496743
##########
File path:
core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala
##########
@@ -1400,19 +1400,20 @@ class AppStatusListenerSuite extends SparkFunSuite with
BeforeAndAfter {
ExecutorLostFailure("2", true, Some("Lost executor")), tasks(3), new
ExecutorMetrics,
null))
- val esummary =
store.view(classOf[ExecutorStageSummaryWrapper]).asScala.map(_.info)
- esummary.foreach { execSummary =>
- assert(execSummary.failedTasks === 1)
- assert(execSummary.succeededTasks === 1)
- assert(execSummary.killedTasks === 0)
+ val allExecutorStageSummary =
store.view(classOf[ExecutorStageSummaryWrapper]).asScala.map(_
+ .info)
+ allExecutorStageSummary.foreach { executorStageSummary =>
+ assert(executorStageSummary.failedTasks === 1)
+ assert(executorStageSummary.succeededTasks === 1)
+ assert(executorStageSummary.killedTasks === 0)
}
val allExecutorSummary =
store.view(classOf[ExecutorSummaryWrapper]).asScala.map(_.info)
assert(allExecutorSummary.size === 2)
- allExecutorSummary.foreach { allExecSummary =>
- assert(allExecSummary.failedTasks === 1)
- assert(allExecSummary.activeTasks === 0)
- assert(allExecSummary.completedTasks === 1)
+ allExecutorSummary.foreach { executorSummary =>
+ assert(executorSummary.failedTasks === 1)
+ assert(executorSummary.activeTasks === 0)
+ assert(executorSummary.completedTasks === 1)
Review comment:
Why the test changed? Looks like it's only a renaming change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
