[GitHub] [spark] beliefer commented on a change in pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.

[GitBox]

beliefer commented on a change in pull request #29754:
URL: https://github.com/apache/spark/pull/29754#discussion_r492497147



##########
File path: 
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -140,6 +140,16 @@ class TaskSchedulerImplSuite extends SparkFunSuite with 
LocalSparkContext with B
     taskScheduler
   }
 
+  private def submitTasksAndCheck(
+      offers: IndexedSeq[WorkerOffer],
+      taskSets: Seq[TaskSet] = Seq(FakeTask.createTaskSet(1)),
+      taskSchedulerOpt: Option[TaskSchedulerImpl] = None) (f: 
Seq[TaskDescription] => Any): Any = {

Review comment:
       OK




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org