srowen commented on a change in pull request #29827: URL: https://github.com/apache/spark/pull/29827#discussion_r493753499
########## File path: .github/workflows/build_and_test.yml ########## @@ -273,6 +273,44 @@ jobs: cd docs jekyll build + webui-tests-with-chrome: + name: WebUI tests with chrome + runs-on: ubuntu-latest + steps: + - name: Checkout Spark repository + uses: actions/checkout@v2 + - name: Cache Maven local repository + uses: actions/cache@v2 + with: + path: ~/.m2/repository + key: webui-tests-with-chrome-maven-${{ hashFiles('**/pom.xml') }} + restore-keys: | + webui-tests-with-chrome-maven- + - name: Install Java 11 + uses: actions/setup-java@v1 + with: + java-version: 11 + - name: Install Chrome and ChromeDriver + run: | + sudo apt update + sudo apt install google-chrome-stable + sudo apt install chromium-chromedriver + - name: Run WebUI tests with Maven + run: | + export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g -Dorg.slf4j.simpleLogger.defaultLogLevel=WARN" + export MAVEN_CLI_OPTS="--no-transfer-progress" + mkdir -p ~/.m2 + ./build/mvn -Dspark.test.webdriver.chrome.driver=/usr/bin/chromedriver \ + -Dguava.version=25.0-jre -Djava.version=11 -Dtest.default.exclude.tags= -Dtest=none \ Review comment: What about just not adding this test? :) How important is it? does this cover new ground? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org