maropu commented on a change in pull request #29585:
URL: https://github.com/apache/spark/pull/29585#discussion_r493980221
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -201,11 +201,6 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]
extends TreeNode[PlanT
case (oldAttr, _) => plan.references.contains(oldAttr)
}
- val (planAfterRule, newAttrMapping) = CurrentOrigin.withOrigin(origin)
{
- rule.applyOrElse(newPlan, (plan: PlanType) => plan -> Nil)
- }
- newPlan = planAfterRule
Review comment:
NOTE: I noticed that we need to update attribute references first, and
then apply a rule into a plan with the updated references. Otherwise, a rule
can see wrong(old) references in a plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
