holdenk commented on a change in pull request #29817:
URL: https://github.com/apache/spark/pull/29817#discussion_r494435828
##########
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -213,9 +207,17 @@ private[spark] class CoarseGrainedExecutorBackend(
logInfo(s"Received tokens of ${tokenBytes.length} bytes")
SparkHadoopUtil.get.addDelegationTokens(tokenBytes, env.conf)
- case DecommissionSelf =>
- logInfo("Received decommission self")
+ case DecommissionExecutor =>
decommissionSelf()
+
+ case ExecutorSigPWRReceived =>
+ decommissionSelf()
+ if (driver.nonEmpty) {
Review comment:
So we don’t ask the driver to stop scheduling jobs on us first, and the
driver could ask us to run a job while we are part way through decommissioning.
This won’t result in a failure because well accept the job but it will slow
down the decommissioning. So swap the order of these two.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
