AngersZhuuuu commented on a change in pull request #29054:
URL: https://github.com/apache/spark/pull/29054#discussion_r496455034
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
##########
@@ -69,7 +69,14 @@ private[sql] class HiveSessionCatalog(
// Current thread context classloader may not be the one loaded the class.
Need to switch
// context classloader to initialize instance properly.
Utils.withContextClassLoader(clazz.getClassLoader) {
- Try(super.makeFunctionExpression(name, clazz, input)).getOrElse {
+ val t = Try(super.makeFunctionExpression(name, clazz, input))
+ if (t.isSuccess) {
Review comment:
> I'd prefer using native `try catch` instead of writing `if else` for
`Try`.
To keep indentation so I change use `try catch` ....
https://github.com/apache/spark/pull/29054#discussion_r452812103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
