Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4435#discussion_r27984083
--- Diff:
core/src/main/scala/org/apache/spark/status/api/v1/OneStageResource.scala ---
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.status.api.v1
+
+import javax.ws.rs._
+import javax.ws.rs.core.MediaType
+
+import org.apache.spark.SparkException
+import org.apache.spark.scheduler.StageInfo
+import org.apache.spark.ui.jobs.JobProgressListener
+import org.apache.spark.ui.jobs.UIData.StageUIData
+import org.apache.spark.util.SparkEnum
+
+@Produces(Array(MediaType.APPLICATION_JSON))
+private[v1] class OneStageResource(uiRoot: UIRoot) {
+
+ @GET
+ @Path("")
+ def stageData(
+ @PathParam("appId") appId: String,
+ @PathParam("stageId") stageId: Int
+ ): Seq[StageData] = {
+ forStage(appId, stageId){ (listener,stageAttempts) =>
+ stageAttempts.map { case (status, stageInfo) =>
+ val stageUiData = listener.synchronized {
+ listener.stageIdToData.get((stageInfo.stageId,
stageInfo.attemptId)).
+ getOrElse(throw new SparkException("failed to get full stage
data for stage: " +
--- End diff --
originally I thought 500 was OK, since it meant some internal inconsistent
state. But now I realize there is a little race condition between when I get
the stage status, and the full stage ui data -- the lock on the listener is
released in the middle, so the stage might get cleaned up in between. I'll
change the way `forStageAttempt` etc. to fix that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
