Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5430#discussion_r28178936
--- Diff:
core/src/main/scala/org/apache/spark/storage/OffHeapBlockManager.scala ---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.storage
+
+import java.nio.ByteBuffer
+import org.apache.spark.Logging
+
+import scala.util.control.NonFatal
+
+
+trait OffHeapBlockManager {
+
+ /**
+ * desc for the implementation.
+ *
+ */
+ def desc(): String = {"OffHeap"}
+
+ /**
+ * initialize a concrete block manager implementation.
+ *
+ * @throws java.io.IOException when FS init failure.
+ */
+ def init(blockManager: BlockManager, executorId: String): Unit
+
+ /**
+ * remove the cache from offheap
+ *
+ * @throws java.io.IOException when FS failure in removing file.
+ */
+ def removeFile(blockId: BlockId): Boolean
+
+ /**
+ * check the existence of the block cache
+ *
+ * @throws java.io.IOException when FS failure in checking the block
existence.
+ */
+ def fileExists(blockId: BlockId): Boolean
+
+ /**
+ * save the cache to the offheap.
+ *
+ * @throws java.io.IOException when FS failure in put blocks.
+ */
+ def putBytes(blockId: BlockId, bytes: ByteBuffer)
+
+ /**
+ * retrieve the cache from offheap
+ *
+ * @throws java.io.IOException when FS failure in get blocks.
+ */
+ def getBytes(blockId: BlockId): Option[ByteBuffer]
+
+ /**
+ * retrieve the size of the cache
+ *
+ * @throws java.io.IOException when FS failure in get block size.
+ */
+ def getSize(blockId: BlockId): Long
+
+ /**
+ * cleanup when shutdown
+ *
+ */
+ def addShutdownHook()
+
+ final def setup(blockManager: BlockManager, executorId: String): Unit = {
+ init(blockManager, executorId)
+ addShutdownHook()
+ }
+}
+
+object OffHeapBlockManager extends Logging{
--- End diff --
private[spark] here too
and add a space after Logging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
