cloud-fan commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506111562
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ########## @@ -76,7 +79,7 @@ class BasicWriteTaskStatsTracker(hadoopConf: Configuration) override def newPartition(partitionValues: InternalRow): Unit = { - numPartitions += 1 + partitions = partitions :+ partitionValues Review comment: this looks like appending a immutable collection. Can we be more explicit? e.g. `partitions.append(partitionValues)` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org