leanken commented on a change in pull request #30097:
URL: https://github.com/apache/spark/pull/30097#discussion_r510549621



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -182,7 +182,7 @@ class Analyzer(
 

Review comment:
       > Could we remove `conf: SQLConf` in the constructor of `Analyzer`?
   
   My original idea is to remove this parameter, but it's causing much more 
changing on the Test code. @cloud-fan , what's your thought?
   
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to