Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/4764#issuecomment-91093315
  
    As a very rough sketch (this is totally untested and I'm probably missing 
cases), I'd hope the solution could look something like the following:
    
    ```scala
    object OptimizeSimpleDistincts extends Rule[LogicalPlan] {
      def apply(plan: LogicalPlan): LogicalPlan = plan transform {
        case Aggregate(Nil, Seq(agg), c) =>
          val rewritten = agg transform {
            case CountDistinct(Seq(c)) => Count(c)
            case SumDistinct(c) => Sum(c)
          }
    
          if (rewritten != agg) {
            Aggregate(Nil, rewritten.asInstanceOf[NamedExpression] :: Nil, 
Distinct(c))
          } else {
            plan
          }
      }
    }
    ```
    
    With tests of course :)  See `FilterPushdownSuite` for an example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to