cloud-fan commented on a change in pull request #29800:
URL: https://github.com/apache/spark/pull/29800#discussion_r510776966
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -355,6 +344,35 @@ abstract class OffsetWindowFunction
*/
val offset: Expression
+ /**
+ * Default result value for the function when the `offset`th row does not
exist.
+ */
+ val default: Expression
+
+ /**
+ * An optional specification that indicates the offset window function
should skip null values in
+ * the determination of which row to use.
+ */
+ val ignoreNulls: Boolean
+
+ /**
+ * Whether the offset is starts with the current row. If `isRelative` is
true, `offset` means
+ * the offset is start with the current row. otherwise, the offset is starts
with the first
+ * row of the entire window frame.
+ */
+ val isRelative: Boolean = true
Review comment:
nit: let's not give a default value here, as it's an important semantic
property.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
