Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5451#discussion_r28194335
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -60,6 +60,7 @@ private[spark] class Client(
def this(clientArgs: ClientArguments) = this(clientArgs, new SparkConf())
+ private var stopMonitor = false
--- End diff --
This would have to be `@volatile`. The problem with this construction is
that several callers to the `monitorApplication` method will now collide, so
I'm not sure this is safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
