imback82 commented on a change in pull request #30079:
URL: https://github.com/apache/spark/pull/30079#discussion_r512047429
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -368,9 +368,13 @@ class ResolveSessionCatalog(
orCreate = c.orCreate)
}
+ case DropTable(
+ r @ ResolvedTable(_, _, _: V1Table), ifExists, purge) if
isSessionCatalog(r.catalog) =>
+ DropTableCommand(r.identifier.asTableIdentifier, ifExists, isView =
false, purge = purge)
+
// v1 DROP TABLE supports temp view.
- case DropTableStatement(TempViewOrV1Table(name), ifExists, purge) =>
- DropTableCommand(name.asTableIdentifier, ifExists, isView = false, purge
= purge)
+ case DropTable(r: ResolvedView, ifExists, purge) =>
Review comment:
You mean to make sure it's a temp view?
For v1, there are few checks for handling views/temp views inside
`DropTableCommand`:
https://github.com/apache/spark/blob/11bbb130df7b083f42acf0207531efe3912d89eb/sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala#L226-L229
Do you want me to copy the checks here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
