otterc commented on a change in pull request #30062: URL: https://github.com/apache/spark/pull/30062#discussion_r512280774
########## File path: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java ########## @@ -172,7 +178,9 @@ protected void serviceInit(Configuration conf) throws Exception { } TransportConf transportConf = new TransportConf("shuffle", new HadoopConfigProvider(conf)); - blockHandler = new ExternalBlockHandler(transportConf, registeredExecutorFile); + shuffleMergeManager = new RemoteBlockPushResolver(transportConf, APP_BASE_RELATIVE_PATH); Review comment: Yes, doesn't seem to be a big change to have a config that is a class. I will add that with this change. @tgravescs ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org