HeartSaVioR commented on a change in pull request #26935:
URL: https://github.com/apache/spark/pull/26935#discussion_r512312263
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
##########
@@ -81,6 +74,40 @@ trait StateStore {
iterator()
}
+ /** Return an iterator containing all the key-value pairs in the StateStore.
*/
+ def iterator(): Iterator[UnsafeRowPair]
+
+ /**
+ * Clean up the resource.
+ *
+ * The method name is to respect backward compatibility on [[StateStore]].
Review comment:
`abort` is only the one which is not properly named in point of
ReadStateStore. It should be `close`, but we found it tricky to respect
backward compatibility with having `close`, hence we decided to leave it as it
is.
Please refer https://github.com/apache/spark/pull/26935#discussion_r493236101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
