AngersZhuuuu commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717013113
> Yes we should ensure the streamState and the totalChunksBeingTransfered are updated synchronically. Other than that the PR looks good! How about current change? Don't use AtomicLong but use `synchronize` to keep strong consistency. And the test result is ``` OneForOneStreamManager fetch data duration test: Stream Size Max Min Avg 10000 1796 187 497.5 50000 4214 1295 2267.9 100000 10635 3643 5800.3 Process finished with exit code 0 ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
