cloud-fan commented on a change in pull request #29800:
URL: https://github.com/apache/spark/pull/29800#discussion_r512451428



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala
##########
@@ -58,7 +58,7 @@ import org.apache.spark.sql.types.{CalendarIntervalType, 
DateType, IntegerType,
  *     4. 1 PRECEDING AND 1 FOLLOWING
  *     5. 1 FOLLOWING AND 2 FOLLOWING
  * - Offset frame: The frame consist of one row, which is an offset number of 
rows away from the
- *   current row. Only [[OffsetWindowFunction]]s can be processed in an offset 
frame.
+ *   current row. Only [[FrameLessOffsetWindowFunction]]s can be processed in 
an offset frame.

Review comment:
       how about `UnboundedOffsetWindowFunctionFrame`? Is it also a "Offset 
frame"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to