gaborgsomogyi commented on a change in pull request #26935:
URL: https://github.com/apache/spark/pull/26935#discussion_r512546512
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
##########
@@ -197,15 +212,26 @@ private[state] class HDFSBackedStateStoreProvider extends
StateStoreProvider wit
}
/** Get the state store for making updates to create a new `version` of the
store. */
- override def getStore(version: Long): StateStore = synchronized {
+ override def getStore(version: Long): StateStore = {
+ val newMap = getLoadedMapForStore(version)
+ logInfo(s"Retrieved version $version of
${HDFSBackedStateStoreProvider.this} for update")
+ new HDFSBackedStateStore(version, newMap)
+ }
+
+ /** Get the state store for reading to specific `version` of the store. */
+ override def getReadOnlyStore(version: Long): ReadStateStore = {
Review comment:
Could we name all the 3 the same way? The method and provider already
`ReadOnly`, can we name the state store too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
