otterc commented on a change in pull request #30062:
URL: https://github.com/apache/spark/pull/30062#discussion_r513185051
##########
File path:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
##########
@@ -94,6 +95,9 @@
static final String STOP_ON_FAILURE_KEY = "spark.yarn.shuffle.stopOnFailure";
private static final boolean DEFAULT_STOP_ON_FAILURE = false;
+ // Used by shuffle merge manager to create merged shuffle files.
+ protected static final String APP_BASE_RELATIVE_PATH =
"usercache/%s/appcache/%s/";
Review comment:
Also I think we don't need a separate `registerApplication` API anymore.
It's just creating an empty `appsPathInfo` for the appId and adds it to the
`appsPathInfo`. This could be done in `registerExecutor`. Even with
`ExternalShuffleBlockResolver` there isn't any registerApplication API.
My next commit will remove this as well.
cc. @Victsm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
