viirya commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-718305957
> I'm sorry to try back and forth, but I feel it weird that StateStoreCodecsTest belongs to StateStoreCompatibilitySuite.scala file. Probably we can just inline StateStoreCodecsTest to StateStoreSuite. Inlining `StateStoreCodecsTest` to `StateStoreSuite` means we need extend `StateStoreSuite` at `StateStoreCompatibleSuite`. It will run duplicate tests in `StateStoreSuite`. And `StateStoreCompatibleSuite` also needs to provide implementation for `newStoreProvider`, `newStoreProvider` and `getLatestData`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org