AngersZhuuuu commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-718413388
> That leads me to wonder, does the value (`numChunksBeingTransferred`) need to be accurate at the specific time? Do we really need to make both updates be in same critical section? Can we tolerate the skew and allow eventual consistent of the value? > (That said, the initial version of the patch looks OK for me.) Agree with this, since this check just gives the customer a configurable number of the largest chunks that are being transferred. WDYT @jiangxb1987 @dongjoon-hyun . ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
