HeartSaVioR commented on a change in pull request #26935:
URL: https://github.com/apache/spark/pull/26935#discussion_r514612885
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
##########
@@ -36,10 +36,14 @@ import org.apache.spark.sql.types.StructType
import org.apache.spark.util.{ThreadUtils, Utils}
/**
- * Base trait for a versioned key-value store. Each instance of a `StateStore`
represents a specific
- * version of state data, and such instances are created through a
[[StateStoreProvider]].
+ * Base trait for a versioned key-value store which provides read operations.
Each instance of a
+ * `ReadStateStore` represents a specific version of state data, and such
instances are created
+ * through a [[StateStoreProvider]].
+ *
+ * `abort` method will be called when the task is completed - please clean up
the resources in
+ * the method.
*/
-trait StateStore {
+trait ReadStateStore {
Review comment:
Ah sorry I reminded the comment from @viirya and still think his comment
makes more sense. I'll rename others to make consistent for now, but I'm also
open to rename this to ReadOnlyStateStore, if both of you think it's better
after reading the comment from @viirya .
@xuanyuanking @gaborgsomogyi Could you please go through the previous
comment below and comment how you think?
https://github.com/apache/spark/pull/26935#discussion_r491747706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
