xuanyuanking commented on pull request #30210: URL: https://github.com/apache/spark/pull/30210#issuecomment-720378892
I think it's ok to change the original param to a SQL config for end users. ``` This change may break some query which may work if end users are super careful and know in details and go ahead. ``` +1 for this concern. So how about change the default value to `false`? ``` I failed to get any voice except @gaborgsomogyi in #24890 and the approach wasn't radical so I did it. ``` Actually, I reviewed that PR after merging :joy:, thanks for the excellent doc! @viirya qq: Do we have the real cases on enabling this config without correctness issues? It would be great to keep updating the document by providing demo cases and specific usage of this config. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
